Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promt for restart on changing generic mode #3605

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Promt for restart on changing generic mode #3605

merged 3 commits into from
Jan 10, 2025

Conversation

Safairette
Copy link
Contributor

Additions

  • The game now prompts for a restart when closing the settings window after toggling the generic ammo setting.

Reasoning

  • The change requires a full restart to apply properly, unlike disabling ammo, which silently re-runs the injection again.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@Safairette Safairette requested review from a team as code owners December 22, 2024 16:41
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12455983764.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 22, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12456005962.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12696464498.zip

@N7Huntsman N7Huntsman merged commit 66b4e47 into Development Jan 10, 2025
3 checks passed
@N7Huntsman N7Huntsman deleted the settings-change-popup branch January 10, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@Thorbane Thorbane Thorbane approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Safairette @Thorbane @N7Huntsman